If FTP Connection fails, there should be a non-zero return

[coreyog]

I'm working to incorporate dploy in the new Bitbucket Pipelines. For whatever reason the FTP connection is failing. Bitbucket Pipelines seems to think everything went fine because dploy seems to be emitting an exit code of 0. For continuous integration, any process failure should result in a non-zero exit code.

[coreyog]

Output from bitbucket pipelines (Note that $FTP_PASSWORD is a bitbucket pipeline that is successfully set up):

+ echo $FTP_PASSWORD | npm run deploy
npm info it worked if it ends with ok
npm info using [email protected]
npm info using [email protected]
npm info lifecycle [email protected]~predeploy: [email protected]

npm info lifecycle [email protected]~deploy: [email protected]

> [email protected] deploy /opt/atlassian/bitbucketci/agent/build
> dploy

– Enter the password for ftp.materialpokedex.com: 

Connecting to live...
Connection failed.
Connection failed.

npm info lifecycle [email protected]~postdeploy: [email protected]
npm info ok 

What was ok about this deploy?