Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong inputs when controller is set to no SODC cleaning. #2

Open
Chinta03 opened this issue Mar 14, 2024 · 7 comments · Fixed by #4
Open

Wrong inputs when controller is set to no SODC cleaning. #2

Chinta03 opened this issue Mar 14, 2024 · 7 comments · Fixed by #4
Assignees
Labels
bug Something isn't working

Comments

@Chinta03
Copy link

Chinta03 commented Mar 14, 2024

Description:
When the controller is set to no SOCD cleaning in order to display on stream the actual inputs on the hitbox controller, the Input Display application does not always show the proper input.

Also a lack of feature to pick which SOCD cleaning to use.

image

image

Prerequisites

  • Own a controller that can be set to no SOCD cleaning mode. (Example: Brooks Universal fighting board fusion)

Reproduction steps

  1. Plug the controller with no SODC cleaning mode
  2. Press the following inputs:
    2.1 Left + right
    2.2 Left + Up + Down

Actual results:
Some inputs combo result in the wrong input in the Input Display.

Expected result:
Show the right input according to the SOCD cleaning rule.

@lucasteles
Copy link
Owner

Thanks for the feedback.

I just got a leverless stick with UFB, I will add a SOCD cleaning option and fix the display

@lucasteles lucasteles self-assigned this Mar 20, 2024
@lucasteles lucasteles added the bug Something isn't working label Mar 20, 2024
@lucasteles lucasteles linked a pull request Mar 21, 2024 that will close this issue
@lucasteles
Copy link
Owner

@Chinta03 I just fixed it. You can test in the latest release.

Note

I probably should evolve the view for SOCD Bypass on multiple opposing inputs. But for now, it is at least showing them correctly.

@Chinta03
Copy link
Author

Chinta03 commented Mar 21, 2024

Hey @lucasteles,
I just tested your new v0.5.1 build and it's still an issue on my side. See the gif below.

SODC_issue
Side note: Windows controller propreties isn't showing the proper inputs either.

I am using a Universal Fighting Board Fusion, set to Controller (XInput STANDARD GAMEPAD) mode.
From what I read, only XInput mode allow SOCD to be displayed.
image

SODC in the InputDisplay Config to SOCD: Neutral.
image

And I am running Windows 10 if this can help.

Cheers!

@lucasteles lucasteles reopened this Mar 25, 2024
@lucasteles
Copy link
Owner

lucasteles commented Mar 25, 2024

@Chinta03 I see. I've tested before with a pad (using a d-pad + analog) to validate the SOCD clean modes. In which mode do you connect the board (which buttons did you hold) on the PC?

The app reads the inputs as Windows does, that's the problem, using my UFB I was able to replicate it.

I need some time to investigate how to bypass this

UPDATE:
The inputs are wrong at SDL level SDL_GameControllerGetButton is returning the wrong DPad buttons (like Windows config)

@Chinta03
Copy link
Author

For my setup. I'm not using any of the Analog inputs, but only the "DPAD" inputs to press opposing directions.
The input mode is "XInput STANDARD GAMEPAD" mode. I tested with some other modes and not all modes could register opposing directions.

@lucasteles
Copy link
Owner

@Chinta03 how did you set this mode up? I could not find it in the Brook docs.

Is it any of these?
image

@Chinta03
Copy link
Author

@lucasteles That would be the XBOX 360 mode, so connecting the USB while holding 3P.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants