-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react] 0.470.0+ crashing deployments #2743
Comments
We're observing the same issue with Next.js 14.2.23 + React 18.3.1. |
Just had the same with remix "@remix-run/node": "^2.15.2", https://crowdfunding-tracker.vercel.app/ fixed it for now by downgrading |
Same here with |
Same here, built fine locally, but deployment on Vercel failed. Downgraded to 0.469.0 and it works again.
|
Same issue in Tanstack Start |
Can you post the the deployment error logs? @rub1e If I run your repo locally it's working, even if I build it. |
Yeah it's really strange, I can build and serve it locally just fine. It's only happening when the site is deployed. Here's everything I get from Netlify logs:
Note the first line and reference to Also note that these aren't deploy logs, they're Netlify Functions runtime logs |
Note I also had this issue running Astro on Vercel. |
I've had the same result with 0.473.0 and 0.474.0. 0.469.0 deploys ok. This is the closest error: |
Can someone check if this is also an issue on |
@ericfennis just tried |
Okay, quite a rabbit hole. Thanks @rub1e for your repro repo, I've set up a Netlify account to research this. I've no deep understanding of how the Node environment or worker's runtime loads module scripts. Since I've tried multiple flavors to figure out what the issue is and what works.
Would be nice if someone could explain more in depth or where I can find some information about this. |
If it's a breaking change we should roll it back and release it with v1, no? |
Looks like its searching for CJS when this should be ECM? |
@jguddas We are a bit checkmate on this. The Dynamic icon needs to have the I've maybe another idea, creating a separate package for the iconNodes and deprecating the Other solution could maybe using a Vite plugin to transform imports like the idea in #1944 . |
I can corroborate that version
|
Confirming the same error happens on AWS Lambda on version
|
shadcn-ui/ui#6585 keeping lucide-react 0.469 due to lucide-icons/lucide#2743
Package
Version
0.470.0+
Can you reproduce this in the latest version?
Browser
Operating system
Description
NOTE: if this is affecting anyone currently, downgrading to 0.469.0 solves it for me
From 0.470.0 using lucide-react icons breaks my
react-router v7
deployments.No problems building locally and serving with
react-router serve
, and no problem runningreact-router build
for the deployment - no errors or warnings.But visiting the page seems to crash the Netlify lambda itself (also tested on Vercel). Here is the error log from Netlify:
Also note that this isn't a react v19 issue, it's happening on 18.3 as well
Steps to reproduce
Here's a minimal repro: https://github.com/rub1e/lucide-react-repro
It's just the Netlify React Router starter with one page with a single lucide icon
Here it is crashing on netlify: https://venerable-sunshine-738964.netlify.app/
Checklist
The text was updated successfully, but these errors were encountered: