-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines: Space inside shape. #935
Comments
These currently do qualify as separate elements and such holes must have a 2px space in preferably all dimensions, but the wording could certainly be improved upon. |
I have reservations about making this a general rule, while it's a good guideline in the strictest sense of the word, I'd make it a suggestion at most, since while sharp corners are something to be avoided certainly not at all costs if sharp corners are a defining characteristic of a shape - the sharp corners may be exactly what's necessary to keep the icon legible. |
I have written a little script that generates a preview and highlights some errors.
Issues in the accessibility.svg icon for example
Solution (without changing the head) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Closing this as a duplicate of #650, I've referenced this issue to be considered when the guidelines are eventually rewritten. |
There already is this rule:
But there is no rule for holes inside shapes.
Proposal to make the gap 2 px as well
The text was updated successfully, but these errors were encountered: