Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines: Space inside shape. #935

Closed
jguddas opened this issue Feb 3, 2023 · 9 comments
Closed

Guidelines: Space inside shape. #935

jguddas opened this issue Feb 3, 2023 · 9 comments
Labels
💡 idea New ideas

Comments

@jguddas
Copy link
Member

jguddas commented Feb 3, 2023

There already is this rule:

Distinct elements must have 2 pixels of spacing between each other.

But there is no rule for holes inside shapes.

Proposal to make the gap 2 px as well

@jguddas jguddas added the 🐛 bug Something isn't working label Feb 3, 2023
@karsa-mistmere karsa-mistmere added 💡 idea New ideas and removed 🐛 bug Something isn't working labels Feb 3, 2023
@karsa-mistmere
Copy link
Member

These currently do qualify as separate elements and such holes must have a 2px space in preferably all dimensions, but the wording could certainly be improved upon.

@jguddas
Copy link
Member Author

jguddas commented Feb 3, 2023

I like the 2px space in all dimensions guideline, it's not really followed for sharper (<90°) corners tho?

@jguddas
Copy link
Member Author

jguddas commented Feb 7, 2023

does this make sens as good vs bad corners?
image

@karsa-mistmere
Copy link
Member

I have reservations about making this a general rule, while it's a good guideline in the strictest sense of the word, I'd make it a suggestion at most, since while sharp corners are something to be avoided certainly not at all costs if sharp corners are a defining characteristic of a shape - the sharp corners may be exactly what's necessary to keep the icon legible.

@jguddas
Copy link
Member Author

jguddas commented Feb 7, 2023

Definitely, legibility over consistency.

What I would love is a script that highlights those guideline violations / suggestion deviations (maybe even as a GH action).

Something like this:

@karsa-mistmere
Copy link
Member

I think this perfectly illustrates why this should be just a suggestion, as in this particular case the suggestions are obviously the bad choice, since human leg, shoulder and arm joints aren't bendy like a rag doll. :)

image

@jguddas
Copy link
Member Author

jguddas commented Feb 11, 2023

I have written a little script that generates a preview and highlights some errors.

  • Arc that has a radius of less than 2px is highlighted
  • Points that are outside the 2x2/22x22 bounding box are also highlighted to enforce the 1px barrier.

Issues in the accessibility.svg icon for example

  • The head is small
  • The body is not connected to the wheel
  • The wheel could be simplified

Solution (without changing the head)

@jguddas

This comment was marked as off-topic.

@karsa-mistmere
Copy link
Member

Closing this as a duplicate of #650, I've referenced this issue to be considered when the guidelines are eventually rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 idea New ideas
Projects
None yet
Development

No branches or pull requests

2 participants