From 3a065537962025169f3464ce82855e49f741ce2f Mon Sep 17 00:00:00 2001 From: lucidrains Date: Sat, 20 Jan 2024 06:31:08 -0800 Subject: [PATCH] remove more inplace ops --- .github/workflows/python-publish.yml | 23 ++++++++++++++--------- nystrom_attention/nystrom_attention.py | 6 +++--- setup.py | 7 ++++--- 3 files changed, 21 insertions(+), 15 deletions(-) diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml index 1a03a7b..3bfabfc 100644 --- a/.github/workflows/python-publish.yml +++ b/.github/workflows/python-publish.yml @@ -1,11 +1,16 @@ # This workflow will upload a Python Package using Twine when a release is created # For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries +# This workflow uses actions that are not certified by GitHub. +# They are provided by a third-party and are governed by +# separate terms of service, privacy policy, and support +# documentation. + name: Upload Python Package on: release: - types: [created] + types: [published] jobs: deploy: @@ -21,11 +26,11 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install setuptools wheel twine - - name: Build and publish - env: - TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} - TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} - run: | - python setup.py sdist bdist_wheel - twine upload dist/* + pip install build + - name: Build package + run: python -m build + - name: Publish package + uses: pypa/gh-action-pypi-publish@27b31702a0e7fc50959f5ad993c78deac1bdfc29 + with: + user: __token__ + password: ${{ secrets.PYPI_API_TOKEN }} diff --git a/nystrom_attention/nystrom_attention.py b/nystrom_attention/nystrom_attention.py index fe25bd9..2b10437 100644 --- a/nystrom_attention/nystrom_attention.py +++ b/nystrom_attention/nystrom_attention.py @@ -107,8 +107,8 @@ def forward(self, x, mask = None, return_attn = False): # masked mean (if mask exists) - q_landmarks /= divisor - k_landmarks /= divisor + q_landmarks = q_landmarks / divisor + k_landmarks = k_landmarks / divisor # similarities @@ -135,7 +135,7 @@ def forward(self, x, mask = None, return_attn = False): # add depth-wise conv residual of values if self.residual: - out += self.res_conv(v) + out = out + self.res_conv(v) # merge and combine heads diff --git a/setup.py b/setup.py index 4446132..6c92c0e 100644 --- a/setup.py +++ b/setup.py @@ -3,9 +3,10 @@ setup( name = 'nystrom-attention', packages = find_packages(), - version = '0.0.11', + version = '0.0.12', license='MIT', description = 'Nystrom Attention - Pytorch', + long_description_content_type = 'text/markdown', author = 'Phil Wang', author_email = 'lucidrains@gmail.com', url = 'https://github.com/lucidrains/nystrom-attention', @@ -14,8 +15,8 @@ 'attention mechanism' ], install_requires=[ - 'einops>=0.3', - 'torch>=1.6' + 'einops>=0.7.0', + 'torch>=2.0' ], classifiers=[ 'Development Status :: 4 - Beta',