Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Category Shared Embedding? #12

Open
LLYX opened this issue Jan 29, 2022 · 3 comments
Open

No Category Shared Embedding? #12

LLYX opened this issue Jan 29, 2022 · 3 comments

Comments

@LLYX
Copy link

LLYX commented Jan 29, 2022

I noticed that this implementation does not seem to have the feature of a shared embedding between each value belonging to the same category (unless I missed it) that the paper mentions (c_phi_i). If it's indeed missing, do you have plans to add that?

Thanks for this implementation!

@lucidrains
Copy link
Owner

lucidrains commented Jan 31, 2022

ohh do you mean one category having multiple values as input?

@LLYX
Copy link
Author

LLYX commented Feb 12, 2022

In the paper they mentioned that each category would have a shared embedding, basically an absolute positional embedding, I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants