Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness of the MemoryAsContextTransformer #32

Open
haohq19 opened this issue Feb 22, 2025 · 0 comments
Open

Correctness of the MemoryAsContextTransformer #32

haohq19 opened this issue Feb 22, 2025 · 0 comments

Comments

@haohq19
Copy link

haohq19 commented Feb 22, 2025

Hi, I'm confused with the implementation of the MACTransformer module. In the paper of Titan, the MACTransformer uses the output of attention to update the NeuralMemory. However, in this implementation, I think the update of NeuralMemory (mem.forward) is conducted before attention. I'm confused if there is something I misunderstand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant