-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve /department/id search view for mobile #931
Comments
3 tasks
This PR does not cover all of the things asked for, but it does address some small pain points for mobile: #965 |
3 tasks
3 tasks
This was
linked to
pull requests
Jul 14, 2023
michplunkett
added a commit
that referenced
this issue
Jul 17, 2023
## Fixes issue #931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this issue
Sep 6, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this issue
Sep 25, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this issue
Oct 5, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this issue
Oct 9, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The view in mobile currently shows only the filter and one has to scroll down to see any results:
![image](https://private-user-images.githubusercontent.com/41744410/248578161-744ba0d7-87fc-4908-b27c-fb7c5c79911b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxMzYxMDgsIm5iZiI6MTcyNDEzNTgwOCwicGF0aCI6Ii80MTc0NDQxMC8yNDg1NzgxNjEtNzQ0YmEwZDctODdmYy00OTA4LWIyN2MtZmI3YzVjNzk5MTFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDA2MzY0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkMDY2ZDFlYWQyZDYwZWFiY2Q5YjkwNjU2ZjliMDkxMWY4NTQzMzFhNTliMTc3M2UzNDRhMzcxNzBkZTc3NzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8IV6EyTtgTLbo-5zNj14hf7XUIIj_cVvLINaTkXaC44)
Additionally the results are paginated and after loading each new page the user has to scroll down again to see the results:
![image](https://private-user-images.githubusercontent.com/41744410/248578363-02d76c34-944a-47f6-bd56-233fb57459d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxMzYxMDgsIm5iZiI6MTcyNDEzNTgwOCwicGF0aCI6Ii80MTc0NDQxMC8yNDg1NzgzNjMtMDJkNzZjMzQtOTQ0YS00N2Y2LWJkNTYtMjMzZmI1NzQ1OWQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDA2MzY0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI0OGFjNGU3ZjE5YjgxY2EzMDA1MjgxOTZiMDk2YTI5NzdlMjEzNmJiNTZlNjIxMWZmNzJiMjg5MTFhY2I5NGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.D8Ey-3t_4YVrR9pWx-iZfDqd7wJoxJBxlCPaSn4BzlI)
Two improvements I have in mind:
Filter officers
collapsible and default to collapsed if the user is on mobileThe text was updated successfully, but these errors were encountered: