Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve /department/id search view for mobile #931

Open
abandoned-prototype opened this issue Jun 26, 2023 · 1 comment · Fixed by #965 or #974
Open

Improve /department/id search view for mobile #931

abandoned-prototype opened this issue Jun 26, 2023 · 1 comment · Fixed by #965 or #974

Comments

@abandoned-prototype
Copy link
Collaborator

The view in mobile currently shows only the filter and one has to scroll down to see any results:
image

Additionally the results are paginated and after loading each new page the user has to scroll down again to see the results:
image

Two improvements I have in mind:

  1. Make the whole Filter officers collapsible and default to collapsed if the user is on mobile
  2. Implement continuous scrolling instead of the current pagination - this will require a new API I imagine. On desktop, I imagine if we can make it work with the filter on the left staying fixed and only the content on the right scrolling down, I think we should have the continuous scrolling for all devices.
@michplunkett michplunkett linked a pull request Jul 11, 2023 that will close this issue
Add filter by photo ability in officer query #965
Merged
3 tasks
@michplunkett michplunkett self-assigned this Jul 11, 2023
@michplunkett
Copy link
Collaborator

This PR does not cover all of the things asked for, but it does address some small pain points for mobile: #965

@michplunkett michplunkett reopened this Jul 12, 2023
@michplunkett michplunkett mentioned this issue Jul 14, 2023
Merged
3 tasks
@michplunkett michplunkett removed a link to a pull request Jul 14, 2023
Add filter by photo ability in officer query #965
Merged
3 tasks
This was linked to pull requests Jul 14, 2023
Add filter by photo ability in officer query #965
Merged
Center and size officer profile pictures #974
Merged
michplunkett added a commit that referenced this issue Jul 17, 2023
@michplunkett
Center and size officer profile pictures (#974)
b462294 
## Fixes issue
#931

## Description of Changes
I centered and addressed sizing issues with the officer profile pictures
in the profile page, officer list page, and officer image page.

## Screenshots (if appropriate)
Located in the comments.

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
@michplunkett michplunkett reopened this Jul 17, 2023
@michplunkett michplunkett removed their assignment Aug 25, 2023
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this issue Sep 6, 2023
@michplunkett @sea-kelp
Center and size officer profile pictures (lucyparsons#974)
8334fe4 
## Fixes issue
lucyparsons#931

## Description of Changes
I centered and addressed sizing issues with the officer profile pictures
in the profile page, officer list page, and officer image page.

## Screenshots (if appropriate)
Located in the comments.

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this issue Sep 25, 2023
@michplunkett @sea-kelp
Center and size officer profile pictures (lucyparsons#974)
03b818a 
## Fixes issue
lucyparsons#931

## Description of Changes
I centered and addressed sizing issues with the officer profile pictures
in the profile page, officer list page, and officer image page.

## Screenshots (if appropriate)
Located in the comments.

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this issue Oct 5, 2023
@michplunkett @sea-kelp
Center and size officer profile pictures (lucyparsons#974)
03b9b50 
## Fixes issue
lucyparsons#931

## Description of Changes
I centered and addressed sizing issues with the officer profile pictures
in the profile page, officer list page, and officer image page.

## Screenshots (if appropriate)
Located in the comments.

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this issue Oct 9, 2023
@michplunkett @AetherUnbound
Center and size officer profile pictures (lucyparsons#974)
d71f60b 
## Fixes issue
lucyparsons#931

## Description of Changes
I centered and addressed sizing issues with the officer profile pictures
in the profile page, officer list page, and officer image page.

## Screenshots (if appropriate)
Located in the comments.

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@michplunkett @abandoned-prototype