Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

training_progress.json can be an invalid json #4016

Open
nqbao opened this issue Jul 15, 2024 · 2 comments
Open

training_progress.json can be an invalid json #4016

nqbao opened this issue Jul 15, 2024 · 2 comments
Labels
bug Something isn't working help wanted Help from the community is welcome

Comments

@nqbao
Copy link

nqbao commented Jul 15, 2024

Describe the bug

I ran ludwig w/o a dev set and look like it generate a json file with Infinity / -Infinity, which is not json valid

    "best_eval_metric_value": -Infinity,
    "best_eval_test_metrics": {},
    "best_eval_train_metrics": {},
    "best_eval_validation_metrics": {},
    "best_increase_batch_size_eval_metric": Infinity,

To Reproduce
Steps to reproduce the behavior:

ludwig train --config train.yml --training_set train.csv --test_set test.csv

try training_progress.json with tools such as jq or something

Expected behavior

Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Python version:
  • Ludwig version 10.0.23

Additional context
n/a

@mhabedank
Copy link
Collaborator

Hi @nqbao thanks for sharing the issue. I will have a look into it.

Context:
https://ecma-international.org/wp-content/uploads/ECMA-404_2nd_edition_december_2017.pdf
Page 4 (PDF: 12)

Numeric values that cannot be represented as sequences of digits (such as Infinity and NaN) are not
permitted.

@mhabedank mhabedank assigned mhabedank and unassigned mhabedank Oct 16, 2024
@mhabedank mhabedank added bug Something isn't working help wanted Help from the community is welcome labels Oct 21, 2024
@mhabedank
Copy link
Collaborator

Related? #3751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Help from the community is welcome
Projects
None yet
Development

No branches or pull requests

2 participants