Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NgramTokenizer #4031

Open
mhabedank opened this issue Oct 21, 2024 · 4 comments
Open

Refactor NgramTokenizer #4031

mhabedank opened this issue Oct 21, 2024 · 4 comments
Labels
dependency help wanted Help from the community is welcome

Comments

@mhabedank
Copy link
Collaborator

mhabedank commented Oct 21, 2024

The NgramTokenizer is using torchtext. We want to remove torchtext as a dependency so this Tokenizer has to be refactored not using it.

@mhabedank mhabedank changed the title Replace Ngramm Tokenizer Replace NgramTokenizer Oct 21, 2024
@mhabedank mhabedank changed the title Replace NgramTokenizer Refactor NgramTokenizer Oct 21, 2024
@mhabedank mhabedank added the help wanted Help from the community is welcome label Oct 21, 2024
@nqbao
Copy link

nqbao commented Oct 21, 2024

if you can provide an example i can help with the rest

@mhabedank
Copy link
Collaborator Author

mhabedank commented Oct 22, 2024

@nqbao
Copy link

nqbao commented Oct 25, 2024

can we just copy the code over?

@mhabedank
Copy link
Collaborator Author

yeah that would probably be the solution for this tokenizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency help wanted Help from the community is welcome
Projects
None yet
Development

No branches or pull requests

2 participants