Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results_as() does nothing #27

Open
Chronial opened this issue Nov 19, 2015 · 3 comments
Open

results_as() does nothing #27

Chronial opened this issue Nov 19, 2015 · 3 comments

Comments

@Chronial
Copy link
Contributor

Just found this bug while browsing the code: The results_as function ignores its keyword argument and just returns a copy of the query.

def results_as(self, constructor):

since this function is also documented nowhere, maybe just remove it?

@Chronial Chronial changed the title results_as does nothing results_as() does nothing Nov 19, 2015
@delijati
Copy link
Collaborator

@lujh @lugensa are you using this in your code base? results_as

@lugensa
Copy link
Collaborator

lugensa commented Nov 19, 2015

Hi,

we do not use this in our code.

@delijati
Copy link
Collaborator

@Chronial feel free to remove that code and send a push request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants