You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a small thing that I just discovered while looking at the code, but if you don't supply a mode parameter to your SolrInterface, you get a read/write interface by default. The code in the __init__ method is:
This is a design question, but I think this would be better if the default was read only. This would require people to create writable interfaces explicitly, which seems important.
This is a breaking API change, so we'll want to consider it carefully, but it seems like a good direction to me.
The text was updated successfully, but these errors were encountered:
mlissner
changed the title
Default mode should not be writable
Default mode should be read only
Oct 12, 2016
This is a small thing that I just discovered while looking at the code, but if you don't supply a
mode
parameter to yourSolrInterface
, you get a read/write interface by default. The code in the__init__
method is:This is a design question, but I think this would be better if the default was read only. This would require people to create writable interfaces explicitly, which seems important.
This is a breaking API change, so we'll want to consider it carefully, but it seems like a good direction to me.
The text was updated successfully, but these errors were encountered: