Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smd.get('missing-key', 'default-value') returns keyerror #51

Open
mbwmbw1337 opened this issue Dec 19, 2021 · 1 comment · May be fixed by #52
Open

smd.get('missing-key', 'default-value') returns keyerror #51

mbwmbw1337 opened this issue Dec 19, 2021 · 1 comment · May be fixed by #52

Comments

@mbwmbw1337
Copy link

Update dict.py to check if dictionary key exists

Ensure dictionary key exists to support common .get() method with default when not existing. Current code throws keyerror even when using a smd.get('non-exist-key', 'default_value')
@mbwmbw1337 mbwmbw1337 linked a pull request Dec 19, 2021 that will close this issue
Open
@renanivo
Copy link

Hi @mbwmbw1337

There's an unit test for that behavior and I could not reproduce it. Can you add the steps to reproduce this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dict.py to check if dictionary key exists glexia/shared-memory-dict
2 participants
@renanivo @mbwmbw1337