Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Complete won't work when typing in single line $$ #57

Open
WuYuanhun opened this issue Apr 23, 2019 · 4 comments
Open

Auto Complete won't work when typing in single line $$ #57

WuYuanhun opened this issue Apr 23, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@WuYuanhun
Copy link

Trying to use latex auto complete, it works when typing as plain text.
It works in multi-line $$.
But when I try to type between in single line $$, the auto complete just does not pop out.

For example, auto complete works in:

$$
\A
$$

but does not work in :

$\A  $
@lukakerr lukakerr added the bug Something isn't working label Apr 23, 2019
@lukakerr lukakerr changed the title [bug] Auto Complete won't work when typing in single line $$ Auto Complete won't work when typing in single line $$ Apr 23, 2019
@WuYuanhun
Copy link
Author

Update the trigger conditions.
The auto complete only works when the character beside '' is in [ ' ', '\n', '\r'].

@WuYuanhun
Copy link
Author

Start to wonder if this is a feature other than bug...

@lukakerr
Copy link
Owner

lukakerr commented Apr 23, 2019

You’re right, there needs to be a whitespace character to the right otherwise autocomplete won’t trigger, this is by design. But this should not occur inside inline maths, since it’s very common to be typing LaTeX commands inside $$ without whitespace.

WuYuanhun added a commit to WuYuanhun/Pine that referenced this issue Apr 28, 2019
Fix Issue lukakerr#57 by add '$' in isWhiteSpace check list.
@WuYuanhun
Copy link
Author

I pull a merge #58 to fix it.
And test on my Mac successfully , (which may have little possibility to cause any problem because only changed a line of code)
Feel free to leave feedback
Thanks for review and Pine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants