Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page should not show if a user was found or not #1524 #1537

Open
lukevella opened this issue Jan 31, 2025 · 5 comments
Open

Login page should not show if a user was found or not #1524 #1537

lukevella opened this issue Jan 31, 2025 · 5 comments

Comments

@lukevella
Copy link
Owner

lukevella commented Jan 31, 2025

Original issue: #1524

When a user tries to login with an email that does not have a registered account, we respond with an error saying that a user does not exist with this email. This allows malicious users to discover which users have a registered account which is a valid security concern. We can avoid exposing this information by proceeding to the verification page and instead mention that a verification code will be sent "if" a user has a registered account with that email.

Image

Additionally, we will need to update the registration flow to not expose when an account already exists and instead send a login email.

Image

@princesinghrajput
Copy link

Hi @lukevella,

I’ve worked on fixing the authentication flow to enhance security by preventing email enumeration during authentication processes.

Could you review the PR when you get a chance?

Here’s the updated flow: https://github.com/user-attachments/assets/c736c4bb-8f5b-4ed0-ba4d-f4bba3b0eedc

Thanks!

@khalidkhankakar
Copy link

Can I work on this issue. Please Assign it to me.

@satonotdead
Copy link

@princesinghrajput just pinging about this issue, it seems the community and project are improving faster 🔥

@felixmanus
Copy link

I am not able to sign up as a user while running the app on my local. I am not receiving any code. I guess it's because of the local environment. In any case, I can't login/signup. Any help?

@satonotdead
Copy link

I am not able to sign up as a user while running the app on my local. I am not receiving any code. I guess it's because of the local environment. In any case, I can't login/signup. Any help?

You should search and/or open a new issue but it seems to be related to your SMTP configurations. You need them prior to use this software.

Read this: https://support.rallly.co/self-hosting/docker-compose#3-configure-your-smtp-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants