Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks of 128 or more items are invisible in the sylladex #554

Open
medsal15 opened this issue Jan 27, 2024 · 5 comments · Fixed by #570
Open

Stacks of 128 or more items are invisible in the sylladex #554

medsal15 opened this issue Jan 27, 2024 · 5 comments · Fixed by #570
Labels
bug Something isn't working as it should

Comments

@medsal15
Copy link

medsal15 commented Jan 27, 2024

The items are still stored in the sylladex and will work as expected, except they are not rendered nor clickable (only for the tree modus). The card also cannot be removed by right-clicking it.

sylladex showing chainmail leggings, 127 chests, and 2 chainmail leggings separated by an empty space

The empty card in the picture is a stack of 128 chests

@kirderf1 kirderf1 added the bug Something isn't working as it should label Feb 23, 2024
@kirderf1
Copy link
Member

The problem is more so that 128+ stack sizes aren't supported by the sylladex in general (specifically in serialization, where the method used limits the stack size to fit a java byte).

However, since the sylladex is meant to adhere to normal stack size limits at the moment, the more relevant problem is how you ended up with those large stack sizes in the first place.

@medsal15
Copy link
Author

I used Nether Chested, which adds a nether chest that can hold 8 times the stack limit in a slot.

@kirderf1
Copy link
Member

Alright. The solution that I want to suggest then is that I make captchaloguing take out one regular-sized stack from the captchalogued inventory slot instead of the whole stack in the slot.

@medsal15
Copy link
Author

The bug can still occur when holding the stack in hand instead of hovering on a slot and captchaloguing.

@kirderf1
Copy link
Member

Seems about right. Captchaloguing a container slot and captchaloguing the held item happens in two different functions. But while a modded container could be changed to hold oversized stacks, I wonder how one might hold an oversized stack in the player inventory.

@kirderf1 kirderf1 reopened this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants