Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psl.get('1.2.3.4') returns last two numbers of IP #29

Open
aalexgabi opened this issue Jul 13, 2018 · 0 comments
Open

psl.get('1.2.3.4') returns last two numbers of IP #29

aalexgabi opened this issue Jul 13, 2018 · 0 comments

Comments

@aalexgabi
Copy link

Example:

> require('psl').get('1.2.3.4')
'3.4'

I think this should return the entire IP and not part of it.

This also does not work with ipv6:

> require('psl').get('2001:0db8:85a3:0000:0000:8a2e:0370:7334')
null

I'm not sure if this is within the scope of this module though. Is this module used to get the domain (in a cookie sense) on which a cookie can be set when given a hostname (domain or ip) or is this module only used to provide the public suffix when given a real domain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant