Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Rules for extremely long lines in lure.sh files #23

Open
JamiKettunen opened this issue Nov 20, 2022 · 3 comments
Open

[RFC] Rules for extremely long lines in lure.sh files #23

JamiKettunen opened this issue Nov 20, 2022 · 3 comments

Comments

@JamiKettunen
Copy link

As an example I was looking at the admc package and the deps_amd64 line is 431 characters long which in my eyes is absurd; not only do you have to scroll a lot horizontally on any device but you absolutely need wordwrap in a text editor to even see it all at a glance!

What would be a fine limit? I think 80 might be a bit too much and would cause many "unnecessary" line breaking everywhere, so maybe 100+ characters limit before lines should be wrapped with a newline, so maybe 120? 160?

Just having some character limit (for situations where it's possible to wrap with newlines) which everything follows would be great to have for the sake of readability :)

@JamiKettunen
Copy link
Author

JamiKettunen commented Nov 20, 2022

I just realized there could be some technical reason for why this is the case, wonder how these scripts are actually parsed exactly

@Elara6331
Copy link
Member

There is no reason. These scripts are parsed by https://github.com/mvdan/sh. I agree. These massive arrays can and should be wrapped to separate lines.

@xpamych
Copy link
Contributor

xpamych commented Dec 6, 2022

I don't see a problem if the line fits on one screen without scrolling, after all the main purpose is to install the package, not to watch the code. Besides, if someone wants to make changes, no one bothers him, the form is absolutely not important to me, the essence is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants