Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library sync can't *remove* categories #710

Open
danieljohnson2 opened this issue Oct 8, 2024 · 0 comments
Open

Library sync can't *remove* categories #710

danieljohnson2 opened this issue Oct 8, 2024 · 0 comments

Comments

@danieljohnson2
Copy link

You can add and remove categories to games in the Lutris client, and then sync, but the server copy only picks up added categories, and does not honor removals.

The behavior you get is that if you do remove a category and sync, the next sync after that will restore the category you removed.

I believe the offending code is in website/accounts/views.py around line 558. You can see this loop only ever adds; there's no removal.

A simple way to fix this might be just test if the new and old category lists match, and if not, clear the server list and copy in all the new categories. I optimistically assume the category lists will always be short!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant