Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdivision assigns wrong node indices in v1.0 #287

Open
luukvdmeer opened this issue Dec 6, 2024 · 0 comments
Open

Subdivision assigns wrong node indices in v1.0 #287

luukvdmeer opened this issue Dec 6, 2024 · 0 comments
Labels
bug 🐛 Something isn't working high priority ⏰ Should be fixed soon to_spatial_subdivision All issues related to function `to_spatial_subdivision()`

Comments

@luukvdmeer
Copy link
Owner

In the new implementation of to_spatial_subdivision() in v1.0, it seems that updating node indices in the from and to columns of the edges table is not always done correctly. Not sure yet why, but this is a serious bug that needs to be fixed soon! Reproduce by loading the Cape Town road network from the sfnetworks workshop (https://luukvdmeer.github.io/sfnetworks-workshop/hands-on.html#cape-town-datasets), converting it into a network with as_sfnetwork(), and then calling to_spatial_subdivision() on it.
@luukvdmeer luukvdmeer added bug 🐛 Something isn't working high priority ⏰ Should be fixed soon to_spatial_subdivision All issues related to function `to_spatial_subdivision()` labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working high priority ⏰ Should be fixed soon to_spatial_subdivision All issues related to function `to_spatial_subdivision()`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luukvdmeer