Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should it remain possible to use select and group_by before any add/filter? #122

Open
maelle opened this issue Jun 8, 2023 · 4 comments
Open

should it remain possible to use select and group_by before any add/filter? #122

maelle opened this issue Jun 8, 2023 · 4 comments

Comments

@maelle
Copy link
Collaborator

maelle commented Jun 8, 2023

@lvaudor

Should

    spq_init() %>%
      spq_select(population, countryLabel) %>%
      spq_group_by("population", "countryLabel")

work?
@lvaudor
Copy link
Owner

lvaudor commented Jun 13, 2023

IMO no, you don't have to make it work...

@maelle
Copy link
Collaborator Author

maelle commented Jun 30, 2023

it currently works, however we might want to add checks in the strict mode introduced in #121

@maelle
Copy link
Collaborator Author

maelle commented Oct 12, 2023

checks added for spq_select in #203

@maelle
Copy link
Collaborator Author

maelle commented Oct 12, 2023

@lvaudor if you like them we could add them for spq_group_by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maelle @lvaudor