Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SwiftPM #3859

Open
adamnemecek opened this issue Nov 16, 2024 · 2 comments
Open

Migrate to SwiftPM #3859

adamnemecek opened this issue Nov 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@adamnemecek
Copy link
Contributor

Is there interest in migrating the project to SwiftPM? If yes, I'm willing to fix it.

@adamnemecek adamnemecek added the enhancement New feature or request label Nov 16, 2024
@lwouis
Copy link
Owner

lwouis commented Nov 16, 2024

Hi,

I'm not familiar with SPM. I haven't used it yet. Do you see practical benefits to switching from cocoapods to SPM?

One thing to consider is that we don't update dependencies often, and we try hard not to add new ones. This is to support our goal for the app to be as performant and lightweight as possible. Another thing to consider is that we commit dependency on git, so cocoapods is not used for people git clone'ing the project. It's only used to download new dependencies on rare occasion.

What do you think? Still worth a shot? Maybe it bundles dependencies in a way which improves performance?

I worry a bit about some of our dependencies which use a fork of popular repos, so we could use our patches. That may be tricky to move to SPM.

Thank you 🙇

@adamnemecek
Copy link
Contributor Author

adamnemecek commented Nov 16, 2024

Do you see practical benefits to switching from cocoapods to SPM?

I do not remember a single time when I cloned a repo using cocoapods and managed to get it to build on the first try or even within like 10 minutes. With SPM that is a pretty common experience. But I did not realize that you do not use cocoapods to pull in the dependencies.

None of the things that you mention should be a show stopper tho. But the whole build process would be simple with SPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants