Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing terminal tab in a window group doesn’t send SIGHUP to the process #51

Open
Rinzwind opened this issue Sep 29, 2022 · 2 comments

Comments

@Rinzwind
Copy link
Collaborator

When closing the tab for a Terminal window that has been put into a window group (use “Create window group” in the window’s window menu) (1.png), the process doesn’t seem to be sent SIGHUP as it doesn’t exit (2.png).

1.png:
1

2.png:
2

@lxsang
Copy link
Owner

lxsang commented Dec 12, 2022

It looks like TerminalEmulator has no way to know whether a window is moved out of a tab group or a window is closed due to the associated tab closed, in both cases, GroupWindowMorph executes the method #removeWindow: without passing any event to TerminalEmulator to differentiate the two cases.

Furthermore, when a GroupWindowMorph is closed, there is no event passing down to the windows in the tab group.

I don't see a consistent way to handle these three cases...

@Rinzwind
Copy link
Collaborator Author

It’s not clear to me either. I’ve reported some issues with window groups in Pharo 11: pharo-project/pharo#12133 and pharo-project/pharo#12134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants