wk4 jan_epic: MTL Manual bug - broken S5 logo/image links

[lijenn]

Identified during John & David's prep s05 on 1/19:

Broken links for logos and images, overall formatting is off.
The chapter looks out of sync in the table of contents too.

https://lzim.github.io/mtl/6-mtl-live-session-05.html#DontClick

[jamesmrollins]

Hi @lijenn - In noted this problem also when I was updating the Test repo on Thursday night. When I have a chance, I will look into this also.

[lijenn]

@jamesmrollins I will be looking into this today, thank you!

[lijenn]

@jamesmrollins I noticed we didn't have a FindReplace.yml for the lzim/mtl gh-pages branch so I added one.
I noticed in bookdown, it likes its .png files to come from the raw source so I tried to FNR .png -> .png?raw=true but it failed with this error code at: https://github.com/lzim/mtl/actions/runs/1743318466

Maybe I missed editing something in the YML file for it work in the gh-pages branch here?
https://github.com/lzim/mtl/blob/fnr-png_bookdown/.github/workflows/FindReplace.yml

Will look more into this myself tmrw, thank you!

FYI @mnallajerla

[jamesmrollins]

Hi @lijenn - I am grasping at a few straws here . . .

Try removing this space

Try adding a wildcard to the argument

find: "*.png"
replace: "*.png?raw=true"

Try escaping the characters

From the jacobtomlinson gha-find-replace issues log

regular expression syntax not documented

Syntax explanation

golang docs on regular expressions

For example

find: ".png"
replace: ".png\?raw\=true"

Or some combination . . . hope this helped!