Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The readme for same_type_signal_name duplicates that for same_signal_function_name #1

Open
JHertz5 opened this issue Sep 9, 2024 · 1 comment · May be fixed by #2
Open

The readme for same_type_signal_name duplicates that for same_signal_function_name #1

JHertz5 opened this issue Sep 9, 2024 · 1 comment · May be fixed by #2

Comments

@JHertz5
Copy link

JHertz5 commented Sep 9, 2024 

$ diff -s ./same_signal_function_name/README.md ./same_type_signal_name/README.md 
Files ./same_signal_function_name/README.md and ./same_type_signal_name/README.md are identical

As a result of the duplication, the readme for same_signal_function_name mentions functions when it should be referring to types.
JHertz5 added a commit to JHertz5/vhdl-examples that referenced this issue Sep 9, 2024
@JHertz5
m-kru#1 Fixed incorrect readme file.
9148ca6
@JHertz5 JHertz5 linked a pull request Sep 9, 2024 that will close this issue
Open
@JHertz5
Copy link
Author

JHertz5 commented Sep 9, 2024

I've raised a PR (#2) to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1 Fixed incorrect readme file. JHertz5/vhdl-examples
1 participant
@JHertz5