Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labyrinth: Декоратор для классов, описывающих уникальные объекты #210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Labyrinth: Декоратор для классов, описывающих уникальные объекты #210

wants to merge 3 commits into from

Conversation

lounres
Copy link
Member

@lounres lounres commented Jun 15, 2019

Made #208.

@lounres lounres added labyrinth-engine Everything that connects with engine in module of Labyritnths. labyrinth-objects Everything that connects with objects in module of Labyritnths. labels Jun 15, 2019
@lounres lounres requested a review from gtivansan June 15, 2019 03:20
@lounres lounres self-assigned this Jun 15, 2019
@lounres
Copy link
Member Author

lounres commented Jun 21, 2019

Ревью так и нет... Ну что ж, придётся поставить таймер: через сутки я мёржу.

gtivansan
gtivansan reviewed Jun 22, 2019
View reviewed changes
labyrinth_engine/labyrinth_object.py
self._metadata.update(kwargs)

add_meta = metadata.setter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот здесь #208 было предложено сделать внешние функции для работы с метаинформацией.
Это было сделано не просто так. Все те описанные там по этому поводу функции работают для любого объекта.
В частности, для функций. (Это можно использовать здесь #75 23 мая)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо. Это, конечно, будет добавлено в LR-75. Но добавлю ещё и здесь. Но это ещё один удобный способ сохранять метаданные у класса LabyrinthObject.

@lounres
Copy link
Member Author

lounres commented Jun 24, 2019

Типа поправил.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtivansan gtivansan gtivansan approved these changes

Assignees

@lounres lounres

Labels
labyrinth-engine Everything that connects with engine in module of Labyritnths. labyrinth-objects Everything that connects with objects in module of Labyritnths.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lounres @gtivansan