Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AndroidX #84

Open
androideveloper opened this issue Nov 21, 2022 · 2 comments
Open

Migrate to AndroidX #84

androideveloper opened this issue Nov 21, 2022 · 2 comments

Comments

@androideveloper
Copy link

Hey,

We are migrating away from support libraries to disable Jetifier and noticed that one of the dependencies that still has android support libs is coming from rn-mparticle sdk. This can be fixed by migrating to AndroidX dependencies. Could you please have a look?

> Task :react-native-mparticle:checkJetifier
The following libraries used by project ':react-native-mparticle' depend on legacy support libraries. To disable Jetifier, you will need to use AndroidX-supported versions of these libraries.
        com.android.support:support-annotations:27.1.1 (Project ':react-native-mparticle', configuration 'debugUnitTestCompileClasspath' -> com.android.support:support-annotations:27.1.1)

As far as I can see it should be simply replacing this dependency https://github.com/mParticle/react-native-mparticle/blob/main/android/build.gradle#L59:

com.android.support:support-annotations:27.1.1 -> androidx.annotation:annotation:1.2.0

@mchuangatmp
Copy link
Contributor

@androideveloper we are working on a fix right now. Thanks for bringing this to our attention

@androideveloper
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants