Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validator too short #139

Open
christenbc opened this issue Apr 9, 2024 · 4 comments
Open

Input validator too short #139

christenbc opened this issue Apr 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@christenbc
Copy link

If I want to search "Up" movie, the validator prevents me to query for it. 2 character should also be allowed.

@christenbc christenbc added the bug Something isn't working label Apr 9, 2024
@primarist
Copy link

^^ Bump, I support this. Several single character movies as well, though I understand how that is problematic from a search perspective. Searching for them using IMDB ID doesn't seem to return anything either.

@mProjectsCode
Copy link
Owner

I think i implemented that because certain APIs will error out when the search is too short

@christenbc
Copy link
Author

Is there a possibility they updated the API? It's a weird limitation to cap the char limit as there are movies named after a single character.

@ltctceplrm
Copy link
Contributor

I was curious so I checked and it is omdbAPI that gives errors when searching for movies with one or two letter names like M or even just Up.

{
    "Response": "False",
    "Error": "Too many results."
}

Unfortunately omdb currently does not allow searching for a query + year, only for title + year but then it only shows the first matching result and wouldn't list all movies with that title in that year. If it was possible to use the query search with the year then you could limit the amount of results and list list all movies with M in it in the year 1931 for example.

There's an open issue for this on the omdb github so if it ever gets added then this could be fixed.

Searching for them using IMDB ID doesn't seem to return anything either.

This does work though if you use search by ID rather than regular search, which ID did you try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants