Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible bug in block fp implementation #15

Open
a-maci opened this issue Aug 30, 2023 · 0 comments
Open

possible bug in block fp implementation #15

a-maci opened this issue Aug 30, 2023 · 0 comments

Comments

@a-maci
Copy link

a-maci commented Aug 30, 2023

mant_adj = mant / power_exp_diff

After shifting the mantissa bits in the above line, the values might become < 1. So the exponents after reconstruction are no longer the same (one can check this after extracting the exponents after line 363 of the reconstructed tensor).

You probably need mant_adj[mant_adj < 1.0] = 1.0 after the above line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant