-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line breaks (new line) are not working #241
Comments
With regular text, the behavior you expect appears to be consistent with hard line breaks, but I found that I can confirm the odd list behavior on There are several issues in glamour that mention broken lists (charmbracelet/glamour#239, charmbracelet/glamour#167) but they do not seem to describe our issue here exactly. Perhaps another issue upstream is warranted? |
@hugginsio i do not know go and don't know how to transform this issue to a glamour issue. since you know all the details, maybe you could assist doing that :) |
@hugginsio friendly ping |
Quick context note and a workaround: Be advised the reason for your initial example to not render a linebreak is that markdown is designed to allow for Semantic Line Breaks, which is why the other syntaxes for explicitly requesting hard breaks exist. It's unfortunate that Glamour doesn't support hard break syntax yet even after a 4+ year old issue. I wanted to render a few short lines with hard breaks, so as a workaround I just wrapped the lines in triple-backticks to treat them as a code block. |
@NReilingh could you share an example? |
@electriquo Try this:
It won't render anything special like bold or emphasis, but if you just want text (like an address block for example) it looks fine. |
Thanks. That's basically just a code block, which loses most of the Markdown power. |
@electriquo Same. I find it very disappointing that Glamour, a library whose only job is to render markdown in the terminal, falls so short so quickly (in my first use of Slides, I started running into glamour issues basically on line 2 of my markdown file). Makes me wonder if a better approach would be a spec-compliant markdown to HTML converter pipelined to a terminal HTML renderer. Don't want my disappointment to reflect badly on @maaslalani -- I'm loving every part of this project that you've put together! |
Describe the bug
2 consecutive lines are being displayed in the same line, rather then in a separate lines
In some cases Slides does not honor new line as one expects, e.g. on lists.
To Reproduce
Steps to reproduce the behavior:
outputs
and
outputs
Expected behavior
A new line needs to be displayed in a new line, e.g. giving the inputs above, the outputs should look like (respectively)
and
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: