Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs better error handler at C code #23

Open
macabeus opened this issue Apr 24, 2019 · 0 comments
Open

Needs better error handler at C code #23

macabeus opened this issue Apr 24, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@macabeus
Copy link
Owner

We are using code written in C at Scissors to resolve compress logic. This code is compiled using emscripten.
To interop the compiled code with the rest of project we have one wrapper to huffman and another wrapper to lzss.

But we have some problems in this interop:

  • since printed messages at C is only passed to console at browser when a \n is printed, some error messages (for example, line 276 at huffman.c and line 227 at lzss.c) isn't showed
  • these errors isn't handled at JS either showed to the user

These errors happens currently. I think that it happens because we are using the same filename to read and to write (see wrappers). We should test if using a different file names these errors are resolved - but we still need make these erros more noticeable.

@macabeus macabeus added the bug Something isn't working label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant