ProgressDlg: only the activity has a finished slot

When a step progress reaches 100%, the progress bar changes to a green background.

Author: antis81

Libs/libMacGitverCore/Widgets/ProgressDlg.cpp

@@ -158,6 +158,10 @@ void ProgressDlg::setPercentage(QObject* activity, const QString& step,
     Q_ASSERT(s);
 
     s->mPercentage = qMin( qMax(percent, 0.), 1. ) * 100.;
+
+    if (s->mPercentage >= 100.) {
+        s->resultChanged(Private::ProgressWdgt::Result::Ok);
+    }
 }
 
 void ProgressDlg::closeEvent( QCloseEvent* ev )
@@ -180,16 +184,6 @@ void ProgressDlg::finished(QObject* activity)
     a->resultChanged(Private::ProgressWdgt::Result::Ok);
 }
 
-void ProgressDlg::finished(QObject* activity, const QString& step)
-{
-    Private::ProgressWdgt* s = findStep(activity, step);
-    Q_ASSERT(s);
-
-    s->mActive = false;
-    s->mPercentage = 100.;
-    s->resultChanged(Private::ProgressWdgt::Result::Ok);
-}
-
 void ProgressDlg::setError(QObject* activity, const QString& message)
 {
     Private::ProgressWdgt* a = mActivities[activity];

Libs/libMacGitverCore/Widgets/ProgressDlg.hpp

@@ -49,7 +49,6 @@ class MGV_CORE_API ProgressDlg : public BlueSky::Dialog
     void setPercentage(QObject* activity, const QString& step, qreal percent);
 
     void finished(QObject* activity);
-    void finished(QObject* activity, const QString& step);
 
     void setError(QObject* activity, const QString& message);