Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to single-click to view submitted captures #298

Open
1 of 3 tasks
machawk1 opened this issue Nov 11, 2019 · 2 comments
Open
1 of 3 tasks

Unable to single-click to view submitted captures #298

machawk1 opened this issue Nov 11, 2019 · 2 comments

Comments

@machawk1
Copy link
Owner

machawk1 commented Nov 11, 2019

Browser reports "Cross-Origin Read Blocking (CORB) blocked cross-origin response" upon clicking IA or archive.is logo post-submission.

This is a blocker for next release.

5bd8875

@machawk1
Copy link
Owner Author

machawk1 commented Nov 11, 2019

https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

The logic for sending the request will need to be moved from the content script (displayMinkUI.js) to the background script (mink.js) and results sent via message passing.

@machawk1
Copy link
Owner Author

In the issue-298 branch, submission to IA now works but submission to AIS needs the revisions in #300. The notification is now broken with this required message passing model but the logic should still be present to propagate the correct message or at least the conditional parameter to attribute the message.

@machawk1 machawk1 pinned this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant