Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of marginalizations seems off #35

Open
aboharbf opened this issue Jul 26, 2021 · 1 comment
Open

Number of marginalizations seems off #35

aboharbf opened this issue Jul 26, 2021 · 1 comment

Comments

@aboharbf
Copy link

So I am implementing this on a Neurons * Time point * Category matrix. Below is some description of my inputs:

  % size(binnedDataStack) = [276    44     8];
  margNames = {'Time', 'Category'};
  combinedParams = {{1, [1 2]}, {2, [2 1]}};

Running the following...
[W, V, whichMarg] = dpca(binnedDataStack, 15);

whichMarg has 3's present, despite me only defining 2 marginalizations. This leads to errors when a 3rd marginalization is being looked for in margNames. Am I using this correctly, and if so, what should I change?

@dkobak
Copy link
Collaborator

dkobak commented Jul 30, 2021

Hmm I am not quite sure what is going on in here, but in any case you should not include [1 2] in both marginalizations, so it should probably be

  combinedParams = {{1}, {2, [2 1]}};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants