You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Been using dPCA for a little bit and noticed when I compared to PCA(whether doing a supervised group average PCA or a trial average PCA), that the cumulative variance explained aren't comparable when data is normalized.
Looking further I noticed the issue that the explained variance ratio calculation in python is incorrect, also outlined in a separate issue here #32
At the very least, it doesn't match the matlab calculation, so at least one of these(python or matlab implementation) is wrong.
Lastly, when I run significance testing, the explained variance ratios are updated, even though I don't think this is the desired behavior.
Not necessarily an issue, but something to be aware of if anyone else is considering using this method in place of PCA.
The text was updated successfully, but these errors were encountered:
Been using dPCA for a little bit and noticed when I compared to PCA(whether doing a supervised group average PCA or a trial average PCA), that the cumulative variance explained aren't comparable when data is normalized.
Looking further I noticed the issue that the explained variance ratio calculation in python is incorrect, also outlined in a separate issue here
#32
At the very least, it doesn't match the matlab calculation, so at least one of these(python or matlab implementation) is wrong.
Lastly, when I run significance testing, the explained variance ratios are updated, even though I don't think this is the desired behavior.
Not necessarily an issue, but something to be aware of if anyone else is considering using this method in place of PCA.
The text was updated successfully, but these errors were encountered: