Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explained variance calculations #45

Open
eduardosand opened this issue Sep 25, 2024 · 0 comments
Open

Explained variance calculations #45

eduardosand opened this issue Sep 25, 2024 · 0 comments

Comments

@eduardosand
Copy link

Been using dPCA for a little bit and noticed when I compared to PCA(whether doing a supervised group average PCA or a trial average PCA), that the cumulative variance explained aren't comparable when data is normalized.

Looking further I noticed the issue that the explained variance ratio calculation in python is incorrect, also outlined in a separate issue here
#32
At the very least, it doesn't match the matlab calculation, so at least one of these(python or matlab implementation) is wrong.

Lastly, when I run significance testing, the explained variance ratios are updated, even though I don't think this is the desired behavior.
Not necessarily an issue, but something to be aware of if anyone else is considering using this method in place of PCA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant