Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace undo does not seem work #13

Open
tobloef opened this issue Nov 29, 2021 · 2 comments
Open

Backspace undo does not seem work #13

tobloef opened this issue Nov 29, 2021 · 2 comments

Comments

@tobloef
Copy link

tobloef commented Nov 29, 2021

On my reMarkable 1, running 2.10, backspace doesn't seem to press the undo button. It changes the cursor position as you would expect, but the character is not deleted.

I would submit a PR myself, but at the moment I'm stuck on not understanding the coordinate system for pressing the button. The Y coordinate is 12100 (see code here), which I can't really see how maps to pixel coordinates. This makes it hard for me to test if it's the position that is wrong, or if it's something else.

Love the project though, I'm looking forward to hopefully contributing in the future.

@machinelevel
Copy link
Owner

Thanks for this! Yep, the backspace functionality relies on the "undo" tool, and that's moved.
I'll try to get an updated position, or maybe a better option. I'm glad you like the project!

@iHnR
Copy link

iHnR commented Jan 23, 2022

I would suggest creating a little config file to set the position of the undo tool. I use ddvk hacks, which I believe changes the position of the undo tool as well. This way the user also has the option to do a quick fix if something changes again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants