Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent alert dialog / sheet shadow #533

Open
hitblast opened this issue Dec 17, 2024 · 9 comments · Fixed by #539
Open

Inconsistent alert dialog / sheet shadow #533

hitblast opened this issue Dec 17, 2024 · 9 comments · Fixed by #539
Labels
bug Something isn't working

Comments

@hitblast
Copy link

Description

On the latest Flutter stable version, the sheets / alert dialogs behave weirdly and only show their shadow color for light mode.

Steps To Reproduce

  1. Make sure the Flutter version is set to 3.27.0
  2. Run the example project pre-included with the library using the following commands:
    cd example && flutter run

Expected behavior

The color should change depending on the appearance / theme mode of the application.

Screenshots

Screenshot 2024-12-17 at 12 15 06 Screenshot 2024-12-17 at 12 15 12
@hitblast hitblast added the bug Something isn't working label Dec 17, 2024
@Adrian-Samoticha
Copy link
Member

What I find interesting is that the main window gets brighter when the alert dialog is shown. Shouldn’t it get darker in dark mode?

@hitblast
Copy link
Author

What I find interesting is that the main window gets brighter when the alert dialog is shown. Shouldn’t it get darker in dark mode?

Yeah, it should get darker with the shadow.

@frankbolviken
Copy link

Whats the status on this project? is it dead? I'm seeing alot of unanswered tasks and milestones from 2023 which have still not been started on etc. Anyone knows? Sorry for hijacking thread, dont want to start a bug report on this

@Adrian-Samoticha
Copy link
Member

@frankbolviken It’s alive, but maintained during our (mine, @GroovinChip’s, and I believe @whiplashoo’s) free time. Unfortunately, it’s quite limited in all of our cases, though PRs are always welcome.

I’ll try to set aside some time for it (and for macos_window_utils) during the Christmas holidays, though.

@frankbolviken
Copy link

@frankbolviken It’s alive, but maintained during our (mine, @GroovinChip’s, and I believe @whiplashoo’s) free time. Unfortunately, it’s quite limited in all of our cases, though PRs are always welcome.

I’ll try to set aside some time for it (and for macos_window_utils) during the Christmas holidays, though.

Nice! Really like it so would be said to see it go.

@Adrian-Samoticha
Copy link
Member

To be frank, I’m not entirely sure what you mean by “shadow color,” as the sheets don’t have any shadow in the first place. I will investigate why the window gets brighter rather than darker, though.

@hitblast
Copy link
Author

To be frank, I’m not entirely sure what you mean by “shadow color,” as the sheets don’t have any shadow in the first place. I will investigate why the window gets brighter rather than darker, though.

Exactly the issue which I'm trying to describe. Sorry if the description was a bit vague.

@Adrian-Samoticha
Copy link
Member

Alright, no worries. I’m on it. :)

Adrian-Samoticha added a commit that referenced this issue Dec 28, 2024
* fix barrier color having wrong color in dark mode

* bump version to 2.1.4

* add changelog entry for version 2.1.4

* automatic changes
@Adrian-Samoticha
Copy link
Member

I forgot to fix the issue for showMacosSheet (I only did it for showMacosAlertDialog). I’ll reopen it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants