Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portlint.tcl: Error if version contains + character #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

portlint.tcl: Error if version contains + character #272

wants to merge 1 commit into from

Conversation

ryandesign
Copy link
Contributor

raimue
raimue approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@raimue raimue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@jmroot
Copy link
Member

jmroot commented May 13, 2022

I'm not totally sold on the wording and it being an error, since it doesn't actually break anything, it just makes it inconvenient to specify the version. I certainly agree that lint should say something about it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimue raimue raimue approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryandesign @jmroot @raimue