Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retdec-devel: update to 20230404 #18401

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

catap
Copy link
Contributor

@catap catap commented Apr 24, 2023

Description

Type(s)
  • enhancement
Tested on

macOS 12.6.3 21G419 x86_64
Xcode 14.2 14C18

Verification

Have you

@kencu
Copy link
Contributor

kencu commented Apr 25, 2023

@jmroot

any better idea for the extract.rename issue here?

@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

@kencu I suggest to use macports/macports-base#289 as discussion to find the better solution to this use-case.

I don't say that suggest approach is good, but it fixes that port.

@kencu
Copy link
Contributor

kencu commented Apr 25, 2023

I just want @jmroot or @ryandesign to sign off on this ahead of the commit rather than have issues with it after.

@jmroot
Copy link
Member

jmroot commented Apr 25, 2023

Better to handle it in the github portgroup for everyone, I would think. (See Trac comments.)

@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

@jmroot anyway it shouldn't be a part of this PR, do you agree?

@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

@jmroot , @kencu maybe merge this PR? It seems quite clear that an issue isn't related to it, and should be fixed inside Github PG or MacPorts itself.

@herbygillot herbygillot merged commit 0b84720 into macports:master Apr 25, 2023
@herbygillot
Copy link
Member

Merging this. We can open a separate PR to enhance the github portgroup if needed.

@catap catap deleted the retdec-devel branch April 25, 2023 23:35
@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

thanks, Herby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants