Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk-m: Update to 2.2.0 #26789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Dave-Allured
Copy link
Contributor

Description

vtk-m: Update 1.7.1.--> 2.2.0

Type(s)
  • Update
Tested on

CI only. OS 13, 14, 15, only.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@reneeotten for port vtk-m.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Nov 27, 2024
@reneeotten
Copy link
Contributor

last time I looked at this PyMOL doesn't build with the latest version. That's the only dependent of this port AFAIK, so if that still gives issues I do not want to update the port at this time.

@Dave-Allured
Copy link
Contributor Author

Yes. It looks like PyMOL requires a specified version of vtk-m, and the latest 2.2 is not in the list. I will take a quick look at PyMOL, and see if there might be an easy fix.

Executing:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_science_pymol/pymol/work/pymol-open-source-3.0.0" && /opt/local/Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12 setup.py --no-user-cfg build -j3 --use-vtkm 2.2 
  usage: setup.py [-h] [--glut] [--no-osx-frameworks] [--jobs JOBS]
                  [--no-libxml] [--use-openmp {yes,no}]
                  [--use-vtkm {1.5,1.6,1.7,no}]
                  [--use-msgpackc {c++11,c,guess,no}] [--help-distutils]
                  [--testing] [--openvr] [--no-vmd-plugins]
  setup.py: error: argument --use-vtkm: invalid choice: '2.2' (choose from '1.5', '1.6', '1.7', 'no')

@reneeotten
Copy link
Contributor

I know and there is already an upstream ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
Development

Successfully merging this pull request may close these issues.

3 participants