Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter dtype checks for integers #35

Open
AKuederle opened this issue Jun 6, 2023 · 0 comments
Open

Stricter dtype checks for integers #35

AKuederle opened this issue Jun 6, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AKuederle
Copy link
Member

With pandas 2.0 and higher, some type conversion got stricter or are not allowed anymore (e.g. you can not convert from float to the new Int64 dtype with safe casting.

To provide better error messages to the user, we should check if the conversion to integeres works for things like stride lists in the is_stride_list (and similar method) and provide actionable error messages

@AKuederle AKuederle added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant