From a717ddf996b4661902106ad4084cd5d4fe8e5d74 Mon Sep 17 00:00:00 2001 From: mohiiit Date: Thu, 19 Dec 2024 23:48:30 +0530 Subject: [PATCH] chore: linting-formatting and readme updated --- README.md | 2 +- e2e-tests/src/node.rs | 5 ++--- e2e-tests/tests.rs | 3 --- madara-bootstrapper | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 1043a782..c807e346 100644 --- a/README.md +++ b/README.md @@ -307,7 +307,7 @@ Setup mode configures the required AWS services and dependencies. Use the following command: ```bash -cargo run --release --bin orchestrator setup --aws --aws-s3 --aws-sqs --aws-sns --aws-event-bridge +cargo run --release --bin orchestrator setup --aws --aws-s3 --aws-sqs --aws-sns --aws-event-bridge-rule ``` Note: Setup mode is currently in development. A fresh setup is required diff --git a/e2e-tests/src/node.rs b/e2e-tests/src/node.rs index b3d3151c..be7c569b 100644 --- a/e2e-tests/src/node.rs +++ b/e2e-tests/src/node.rs @@ -58,8 +58,7 @@ impl Orchestrator { .arg("--aws") .arg("--aws-s3") .arg("--aws-sqs") - .arg("--aws-sns") - .arg("--aws-event-bridge-rule"); + .arg("--aws-sns"); // Add event bridge arg only for setup mode if is_run_mode { @@ -75,7 +74,7 @@ impl Orchestrator { command.stdout(Stdio::piped()).stderr(Stdio::piped()); } else { - command.arg("--aws-event-bridge"); + command.arg("--aws-event-bridge-rule"); // For setup mode, inherit the stdio to show output directly command.stdout(Stdio::inherit()).stderr(Stdio::inherit()); diff --git a/e2e-tests/tests.rs b/e2e-tests/tests.rs index 02dbd3b2..ed72488b 100644 --- a/e2e-tests/tests.rs +++ b/e2e-tests/tests.rs @@ -167,9 +167,6 @@ async fn test_orchestrator_workflow(#[case] l2_block_number: String) { println!("✅ Orchestrator setup completed."); - let trigger_rule_name = &get_env_var_or_panic("MADARA_ORCHESTRATOR_EVENT_BRIDGE_TRIGGER_RULE_NAME"); - let target_queue_name = &get_env_var_or_panic("MADARA_ORCHESTRATOR_EVENT_BRIDGE_TARGET_QUEUE_NAME"); - // Run orchestrator let mut orchestrator = Orchestrator::new(OrchestratorMode::Run, setup_config.envs()).expect("Failed to start orchestrator"); diff --git a/madara-bootstrapper b/madara-bootstrapper index b0b64750..f717bf17 160000 --- a/madara-bootstrapper +++ b/madara-bootstrapper @@ -1 +1 @@ -Subproject commit b0b647500c2ae3e3b0d99e345fa652989bca4726 +Subproject commit f717bf179581da53d68fee03b50ef78e0628ee20