Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate conversion functions for all crates. #84

Closed
heemankv opened this issue Aug 16, 2024 · 1 comment
Closed

Evaluate conversion functions for all crates. #84

heemankv opened this issue Aug 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@heemankv
Copy link
Contributor

With continuous development of the orchestrator we have come to notice that
the amount of conversion functions have increases a lot,
especially in the ethereum-settlement-client crate, we would ideally want to reduce them and implement generics.
(instead of implement a method for both size 32 and size 48, we can use a generic maybe)

@heemankv heemankv added the enhancement New feature or request label Aug 16, 2024
@heemankv heemankv self-assigned this Aug 16, 2024
@heemankv
Copy link
Contributor Author

heemankv commented Sep 6, 2024

Code betterment through various PRs have made this issue insignificant,
eg : ethereum-settlement-client was refactored by PR #81.
Overall the codebase as of now has conversion functions defined for their specific scope, with no excess.

@heemankv heemankv closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant