Fixed issue with Chrome zoom #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been experiencing this issue too, and came to the same conclusion independently. As I was about to submit a PR, I noticed this, which seems to fix the issue. Can you merge it, please, so we don't have to maintain a separate branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chrome, when the zoom is active, the following behavior is observed :
See https://bugs.chromium.org/p/chromium/issues/detail?id=507801
As a result the animated scroll doesn't work when the zoom is active. This PR fixes that by setting
lastposwith the actual value ofelement.scrollTop.Fixes #5