Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up year range in copyright statements #817

Closed
valassi opened this issue Feb 13, 2024 · 1 comment · Fixed by #842
Closed

Clean up year range in copyright statements #817

valassi opened this issue Feb 13, 2024 · 1 comment · Fixed by #842
Assignees

Comments

@valassi
Copy link
Member

valassi commented Feb 13, 2024

Hi @roiser I move your concerns here from #809 (comment) because that PR is now merged and closed

Repeating your and my comments:

<< SR: Really minor comment and I propose not to revert this, but there is no need to bump up the copyright year numbers, see e.g. blog post https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code (got the link from the CERN open source policy office OSPO)

AV: interesting point... i was actually going to propose that we update all copyright statements to be 2020-2024 in the code, now I am a bit less sure after reading your blog post

i must say i still have a preference for having all copyright statements updated to 2020-2024: i mean that post suggests you do not need to update the years, but it is not saying that you should absolutely not do that... I find it visually more clear on the one hand, and on the other hand it IS true that we are continually updating the code... and in any case yes 50-70 years are a long time, so it makes a little difference...

I think I would especialy like a self consistent practice throughout the code: for instance, we put 2020-2024 everywhere, or we put 2020 (or year of first publication if >2020) everywhere... thoughts? >>

@valassi valassi self-assigned this May 15, 2024
@valassi valassi linked a pull request May 15, 2024 that will close this issue
@valassi
Copy link
Member Author

valassi commented May 15, 2024

I finally updated the copyright range in PR #842, now merged. Closing

@valassi valassi closed this as completed May 15, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant