Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master_june24 builds fail for FPTYPE=m #884

Closed
valassi opened this issue Jul 4, 2024 · 1 comment
Closed

master_june24 builds fail for FPTYPE=m #884

valassi opened this issue Jul 4, 2024 · 1 comment
Assignees

Comments

@valassi
Copy link
Member

valassi commented Jul 4, 2024

Another issue introduced in #830 and being reviewed in #882.

Related to the tests in WIP PR #882:

master_june24 builds fail for FPTYPE=m

https://github.com/madgraph5/madgraph4gpu/actions/runs/9795940525/job/27049275249


FPTYPE='m'
HELINL='0'
HRDCOD='0'
HASCURAND=hasNoCurand
HASHIPRAND=hasNoHiprand
Building in BUILDDIR=. for tag=avx2_m_inl0_hrd0_hasNoCurand_hasNoHiprand (USEBUILDDIR != 1)
make -C ../../src  -f cudacpp_src.mk
make[2]: Entering directory '/home/runner/work/madgraph4gpu/madgraph4gpu/epochX/cudacpp/ee_mumu.mad/src'
g++  -I. -O3  -std=c++17 -Wall -Wshadow -Wextra -ffast-math  -fopenmp  -march=haswell  -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_FLOAT -fPIC -c read_slha.cc -o read_slha_cpp.o
g++  -I. -O3  -std=c++17 -Wall -Wshadow -Wextra -ffast-math  -fopenmp  -march=haswell  -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_FLOAT -fPIC -c Parameters_sm.cc -o Parameters_sm_cpp.o
g++ -shared -o ../lib/libmg5amc_common_cpp.so ./read_slha_cpp.o ./Parameters_sm_cpp.o 
make[2]: Leaving directory '/home/runner/work/madgraph4gpu/madgraph4gpu/epochX/cudacpp/ee_mumu.mad/src'
g++  -I. -I../../src -O3  -std=c++17 -Wall -Wshadow -Wextra -ffast-math  -fopenmp  -march=haswell  -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_FLOAT -fPIC   -DMGONGPU_HAS_NO_CURAND -DMGONGPU_HAS_NO_HIPRAND -c check_sa.cc -o check_sa_cpp.o
g++  -I. -I../../src -O3  -std=c++17 -Wall -Wshadow -Wextra -ffast-math  -fopenmp  -march=haswell  -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_FLOAT -fPIC -c CPPProcess.cc -o CPPProcess_cpp.o
CPPProcess.cc: In function ‘void mg5amcCpu::sigmaKin(const fptype*, const fptype*, const fptype*, const fptype*, mgOnGpu::fptype*, const unsigned int*, mgOnGpu::fptype*, mgOnGpu::fptype*, int*, int*, int)’:
CPPProcess.cc:1143:70: error: ‘channelId’ was not declared in this scope; did you mean ‘channelIds’?
 1143 |         const unsigned int iconfigC = mgOnGpu::channelId_to_iconfigC[channelId]; // coloramps.h uses a channel ordering not the diagram id
      |                                                                      ^~~~~~~~~
      |                                                                      channelIds
CPPProcess.cc:1154:32: warning: declaration of ‘iconfigC’ shadows a previous local [-Wshadow]
 1154 |             const unsigned int iconfigC = mgOnGpu::channelId_to_iconfigC[ichannelIds[i]];
      |                                ^~~~~~~~
CPPProcess.cc:1143:28: note: shadowed declaration is here
 1143 |         const unsigned int iconfigC = mgOnGpu::channelId_to_iconfigC[channelId]; // coloramps.h uses a channel ordering not the diagram id
      |                            ^~~~~~~~
make[1]: *** [cudacpp.mk:700: CPPProcess_cpp.o] Error 1
make[1]: Leaving directory '/home/runner/work/madgraph4gpu/madgraph4gpu/epochX/cudacpp/ee_mumu.mad/SubProcesses/P1_epem_mupmum'
make: *** [makefile:142: .cudacpplibs] Error 2
make: Leaving directory '/home/runner/work/madgraph4gpu/madgraph4gpu/epochX/cudacpp/ee_mumu.mad/SubProcesses/P1_epem_mupmum'
Error: Process completed with exit code 2.
@valassi valassi self-assigned this Jul 4, 2024
@valassi valassi changed the title master_june40 builds fail for FPTYPE=m master_june24 builds fail for FPTYPE=m Jul 4, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Jul 4, 2024
…e an old unnecessary definition of iconfigC causing build errors (madgraph5#884)

This is clearly a remnant of old code (it still uses channelId instead of channelIds with trailing 's') that should have been removed
It only affects FPTYPE=m builds
@valassi
Copy link
Member Author

valassi commented Jul 4, 2024

I committed a fix in #882 which I believe will fix it (running tests now). Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant