Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Random #123

Merged
merged 2 commits into from
Mar 15, 2024
Merged

add Random #123

merged 2 commits into from
Mar 15, 2024

Conversation

brekk
Copy link
Contributor

@brekk brekk commented Jul 28, 2023

Test.mad

  • Changes to AssertionError to afford mixed results when asserting multiple times in a test

List.mad

  • set - Set the value at a given index in the list
  • setMaybe - Set the value at a given index in the list, maybe

Random.mad

A bunch of stuff here, but the core API is:

  • generate - Create a PRNG instance from an integer seed
  • generateFromString - Create a PRNG instance from a string seed

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (a16bfa0) to head (fe20f4b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files          81       81           
  Lines       11460    11460           
=======================================
  Hits         8492     8492           
  Misses       2968     2968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brekk brekk requested a review from aboeglin March 15, 2024 20:20
Copy link
Contributor

@aboeglin aboeglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think we should probably fix that List import and definitely look at addIndex before merging it.

@brekk brekk requested a review from aboeglin March 15, 2024 20:48
Copy link
Contributor

@aboeglin aboeglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice nice!

@brekk brekk merged commit 266ef62 into master Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants