Command Combos

[madprops]

Next version will have this:

You can define 10 combos. Each combo is a list of commands:

They appear in the palette:

And they can be assigned like normal commands:

[N3C2L]

Wow! Love that!
I just tried it, but have a problem:
I have a combo here with this 3 cmds:
Filter Domain
Close Visible
Enter Key
But the problem is, that the enter key is not working for the popoup that will close visible tabs.
Can you confirm that?
Edit: Just realized that I would need another double enter for the close visible popup.
And I have another combo:
Unload others
Enter Key
But I can't add another Enter Key in the combos menus (2x Enter key after another), that would be cool to confirm the double enter in the unload others popup.

[madprops]

I'll look into it. It's a primary key issue since 'cmd' is the primary key so it doesn't allow duplicates. I dealt with this a few days ago on a similar issue, i'll look into it

Other thing to keep in mind is that they're executed top to bottom, so you might have to order the list.

Maybe I should make it so adding items are appended instead of prepended.

[N3C2L]

Thanks for looking into it! From top to bottom, yes.
It's a good idea to make new items appended! Then we don't have to reorder them manually afterwards.

[madprops]

Ok next version will fix this. Turns out you don't need a second Enter. The synthetic Enter was triggering a keydown but not a keyup and I check enter keys on keyup. So now I'm making all Keys to trigger both keydown and keyup. (Well you need 2 enters to confirm the popup, this won't work if 0 items are selected)

Also combos will be able to add duplicate commands since I fixed the primary key issue.

And now list items are appended.

These new settings might be useful:

These will be in More.

Also this one:

[N3C2L]

Thank you! All of your changes work flawlessly in my combos. It's truly a pleasure to bite into these combo burgers. And thank you also for the new settings "tab close pins" and "tab close unloaded" - I've naturally activated both of them right away.

[N3C2L]

I have another small problem 😁
I often use edit title cmd for renaming my tabs. I'd love a combo for this, and created one:
Edit Title
Left Key
But I think the left arrow key doesn't register here in this renaming dialog.

[madprops]

Good timing, I was about to upload new version. I'm taking a look.

[madprops]

I don't think that's possible. I tried dispatching the event on the input directly too:

Triggering a keydown event programmatically using new KeyboardEvent('keydown', { key: 'ArrowLeft' }) might not produce the desired effect because many browser behaviors associated with keyboard events are considered "trusted" events, meaning they need to originate from actual user actions to be recognized fully.

Is the intended action to place the caret at the start of the title? This could be fixed through a setting

Right now it auto highlights the text if Edit Title Auto in More is checked

[N3C2L]

I see. Yes, you are right. It's intended to place the caret at the start of the title. I do this often on video tabs for example "min24:20" at the start of the tab, where I left the video and unload the tab afterwards.

[madprops]

Well the highlight behavior is the default since you requested it if I remember correctly. I can change the default of how this works. Fill the title but instead of highlighting put caret at start. Though highlighting might be more flexible since you can press left arrow or right arrow.

[N3C2L]

Yes I was requesting it, thanks for implementing it!
That would be great if this could be changed to put the caret at the start.

[madprops]

I'm changing that default but added a setting for highlight which can be enabled to restore old behavior.

Actually I'm gonna add this to General:

[N3C2L]

Great! A small problem is, when I have added the edit title cmd to a browser cmd in about:addons, then the edit title dialog gets no focus for input. You can test this when changing tabs and try this browser cmd with the keyboard. I think it's because it's focusing the website instead of the renaming dialog. It's working only when you click the tab before.

[madprops]

Yeah I don't think that's possible yet

https://bugzilla.mozilla.org/show_bug.cgi?id=1912558

[madprops]

Shortcuts work because there's signals sent from the background script to the sidebar. But the sidebar doesn't get actual focus as you need to click it manually

[N3C2L]

Alright, thanks for this clarification.

[N3C2L]

Hmm, a solution would be to run the grasshopper popup instead of the sidebar. Then the input is there. For cmds useful where keyboard input afterwards is useful:
"close menu"
"add tag"
"edit title"
Could be 5 other "popup" shortcuts in the "browser" section. When added there, the popup will run with the shortcuts set in about:addons.

Edit: There could be a setting that automatically closes the grasshopper popup if a prompt has been closed. This would be awesome for quick editing, and we don't need to press the ESC key after the prompt to escape the grasshopper popup.

[madprops]

Next version will have 10 of those.

popupcommands.mp4

It auto closes on prompt hide if it was spawned via a popup command.

This is going a bit into 'hack' territory as it relies on timeouts, but it works.

Also I'm gonna make Prompt Mode: At End, the default as it is more natural but you can change it in General.

[N3C2L]

This is awesome! Thanks!

[N3C2L]

It would be very convenient if a user could rename combos.

Especially when many commands are to be executed in sequence, one wants to be absolutely sure with a proper naming of the combos before executing them.

Also, because it would make the menus containing these combos easier to read. I think if colors can be named, it should also be possible with combos.

What do you think about that?

[madprops]

Yeah makes sense. Also should name the new Generic Menus.

I might make it so name and icon can be defined.

[madprops]

[madprops]

Also added a shortcut when you click Save on an addlist. If you hold Shift or Ctrl when clicking, it will reverse the insert method. For instance instead of appending to the bottom of the list, it will prepend it.

[madprops]

[madprops]

I'm thinking now if these should be created dynamically in infinite number.

However there's no addlist within addlist ability right now.

[madprops]

An option is to create an addlist where combos can be created but with a fixed number of possible commands, like 5 commands. Do you think more than 5 commands might be needed in a combo? I would also add a delay option per combo. I like that idea because Combos are basically command factories with 1 or more commands.

[madprops]

It would look like this:

[madprops]

I'll make it 10 commands.

[N3C2L]

Well, I like this idea of the infinite list of factory combos 😁
Yeah, I think the number of max 10 is more than enough for everything.
Also very good the icon idea with every combo. Make the menus shine even more with that. Thanks for that!

[madprops]

Don't worry I think I won't change it. At least not the generic menus. Not sure what I'll do.

Well I guess we'll have to remake our command combos now.

I'm moving it to General.

But it's more orderly I guess.

[N3C2L]

I'm totally fine with 10 combos as it is now. I don't even have all 10 combos slots filled with cmds. (I have 5 filled atm.). I don't know what you mean with the generic menus.

[N3C2L]

Sorry if I misunderstood what you wrote, not a native speaker. What did you mean with "dont worry I think wont change it?"

[madprops]

I was going to revert the changes. But I think it's better this way.

Didn't want to bother you with re-making the combos.

[madprops]

I'll leave it as it was then. But with names and icons.

[N3C2L]

Ah, got it, thank you 😁

[madprops]

Ok new version up.

[madprops]

Take note of current combos because I am gonna change it to the addlist mode.

They'll be in General as an addlist next to Custom URLs.

[N3C2L]

Alright, I took screenshots of them. Thanks for the addlist mode! 👍

[madprops]

I'm enhancing addlist command widgets so they can be re-ordered by drag and dropping.

Also I'm making the ability to compose combos inside other combos, which wait until the combo item finishes before running the next item.

[N3C2L]

Good enhancements, thanks!

[N3C2L]

I guess there is a little problem with combos, I'd be cool if you could look into it:
Specifically the "step back" command when it comes to focusing on the last used tab: Suppose you filter the list with the "Filter Titled" command and then use the "step back" command to focus on the active tab. The problem arises that the filtering mode reverts to "All" and focuses the tab there. But what if someone wants to focus on the active tab in the "Filter Titled" filtering with a command or combo? This is currently not possible with the step back command.

Small other problem but below also a combo relation:
Maybe this is a bug: Please repro: Settings>Trigger>Click Press Item set it to "Filter Loaded".
Then try to "click press" a tab with it. Result: The actual tab is not selected in the "Filter Loaded" view. But this is strange, because if I set "Click Press" to "Unload Tab" the tab will get selected, because otherwise the tab wouldn't get unloaded. So this cmd is working there.
But due to this problem from above: Do you think it would make sense to add commands like "select tab under mouse cursor" or "left mouse click" to the available combo options? Because what if other commands or combos do need this tab activation for example keyboard shortcuts when executed from them.

[madprops]

#1 is confusing. Active means the current focused/open tab btw. So I guess you mean selected tab, but that could be anything, not sure I see a problem here.

#2 I'm not seeing the filter load problem, when I click press a tab I see it being included in the filter. Maybe the tab is unloaded in your case? (Oh you mean is not selected I see).

I'll check if those 2 command additions make sense.

I'm gonna add left click command but I don't know if it's gonna help.

What I'm gonna do is keep selected item on filters, through a setting, default true I guess. So you could select the item first and then do the filter loaded and it will keep the item selected.

[N3C2L]

1. Thank you for the new "Filter Keep Selected" function, it's very helpful for switching between filters while maintaining the current tab. However, it might have been good to introduce a command like "Focus current tab". Because when I'm within a filter, e.g., "Filter Loaded", and then scroll somewhere, the "step back" command would take me back to the "All" filter. However, with new cmd "Focus current tab" or maybe "Focus active Tab", one would want to stay in the current filter "Filter Loaded" and focus the active tab there instead of using the "Step Back" cmd wihich takes him to the "All" view and focuses the tab here.

2. Thank you for the new "Left Click" command. With this, I've now been able to create a combo on "Click Press" that goes: 1. Left Click 2. Filter Loaded. This allowed me to have the desired tab immediately focused in the Filter Loaded view because your "filter keep selected" option is now activated.

[madprops]

Ok I'm modifying step back to have a step where it selects active tab if not selected, while keeping the filter.