Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search highlighting #25

Closed
maelchiotti opened this issue Apr 12, 2024 · 2 comments · Fixed by #394
Closed

Add search highlighting #25

maelchiotti opened this issue Apr 12, 2024 · 2 comments · Fixed by #394
Assignees
@maelchiotti
Labels
enhancement New feature or request

Comments

@maelchiotti
Copy link
Owner

maelchiotti commented Apr 12, 2024 •
edited
Loading

Highlight search terms in the title/content of the list tiles in the search view.

Highlightable could work great for this, but if the text to highlight isn't in the first 3 lines then it is not shown.

To fix that, maybe use an extraction method from a fuzzy search.
@maelchiotti maelchiotti converted this from a draft issue Apr 12, 2024
@maelchiotti maelchiotti added the enhancement New feature or request label Apr 12, 2024
@maelchiotti maelchiotti changed the title Improve search Add search highlighting Apr 12, 2024
@maelchiotti maelchiotti self-assigned this Apr 17, 2024
@maelchiotti
Copy link
Owner Author

maelchiotti commented Apr 27, 2024 •
edited
Loading

Big performance issues with fuzzy search when there are a lot of notes with long content. Won't do for now.

@github-project-automation github-project-automation bot moved this from To do to Done in LocalMaterialNotes Apr 27, 2024
@maelchiotti maelchiotti added the wontfix This will not be worked on label Jun 7, 2024
@HarriBuh HarriBuh mentioned this issue Nov 23, 2024
Closed
@maelchiotti maelchiotti reopened this Feb 12, 2025
@maelchiotti
Copy link
Owner Author

Limitation: text that is after the lines limit will not be shown, but that is a limitation that even Messenger doesn't care about so...

@maelchiotti maelchiotti moved this from Done to In progress in LocalMaterialNotes Feb 12, 2025
@maelchiotti maelchiotti removed the wontfix This will not be worked on label Feb 12, 2025
@maelchiotti maelchiotti linked a pull request Feb 12, 2025 that will close this issue
[25] Highlight search text #394
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in LocalMaterialNotes Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maelchiotti maelchiotti

Labels
enhancement New feature or request
Projects
LocalMaterialNotes
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[25] Highlight search text maelchiotti/LocalMaterialNotes
1 participant
@maelchiotti