-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing frames #47
Comments
Hello, post the mediainfo of your file (obtained from the app or https://mediainfo.js.org/). As for why lossless isn't actually lossless, it might be because the bit depth isn't set in the command - so maybe try adding -pix_fmt yuv420p10le if your input is 10 bit. Not sure why the black frames are appearing but might be explained by the mediainfo. Enhancr hasn't been updated a while so maybe the current version is unable to decode the frames correctly? Just a guess Also just so you are aware, most Real-ESRGAN models are very destructive in terms of quality so proceed with caution. |
If you want something truly lossless try: So AV1 seems to cause black frames and you haven't managed to get FFV1 to work. I don't see anything wrong with the AV1 file besides it not being 10 bit (which, if you are using AV1, is highly recommended) but that shouldn't be the cause of the issue. Maybe try encoding a YUV FFV1 file using the command shown above and see if the issue still occurs? Also it does seem like Real-ESRGAN is nuking quite a bit of detail so perhaps you should look into using a different model or maybe even a shader based scaler like ArtCNN. |
So, png to ffv1 to png is causing most pixels to end up being slightly off when using yuv, even with a bit depth of 14. Not that big of a deal, but it's weird. I tried Enhancr on that with ShuffleCUGAN and two ESRGAN models. It was unable to use lollypop, but the other two passed with the same blocky compression effect. Another implication this is video compression is that it's less significant on the first frame. Same issue with frame alignment: it starts with a black frame and the last two are missing. |
I performed tests on the upscaling and interpolation separately using a short video after finding these issues with a longer video. I believe the input videos are not the cause after analysis with ffmpeg (extracting frames as PNGs) and ffprobe.
The upscaling output has two added black frames at the beginning, is missing the first frame of the input, and is missing the last two frames of the input. It has the same number of frames as the input.
The interpolation output (exactly twice the number of frames as the input) is as follows:
First frame: black
Second frame: interpolation between black and first input frame
Last two frames: second-to-last input frame (no interpolation to, nor copy of, the last input frame)
It also seems that Enhancr applies lossy compression regardless of the output format, as the quality of subtle gradients in the video noticeably degraded, looking posterized and having jagged seams.
Enhancr version: 0.9.9 free
Input video: exported from Blender sequencer as .mkv with AV1, 19 frames at 60 fps (ffprobe reports a duration of 0.38 seconds, 0.317 for the video stream specifically)
Output format: Lossless frame sequence with no added ffmpeg parameters
Upscaling method: RealESRGAN (DirectML)
Interpolation method: RIFE 4.6 (NCNN)
The text was updated successfully, but these errors were encountered: